Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix provider release through correct zipping #2778

Merged
merged 1 commit into from
Dec 27, 2023

Conversation

elchead
Copy link
Contributor

@elchead elchead commented Dec 27, 2023

Context

The current Terraform provider release is broken because of wrong zipping.
Terraform expects the zip files to only contain the binary file, but our zip inflates to a directory. This leads to TF not finding the binary:
https://github.com/edgelesssys/constellation/actions/runs/7339043840/job/19982584425#step:18:62

See the relevant zipping line:

zip -r "${folder_name}.zip" "${folder_name}"

You can check that this is done correctly for the edgelesstest, which works:

unzip terraform-provider-edgelesstest_1.0.0_linux_amd64.zip
Archive:  terraform-provider-edgelesstest_1.0.0_linux_amd64.zip
  inflating: CHANGELOG.md
  inflating: LICENSE.txt
  inflating: README.md
  inflating: terraform-provider-edgelesstest_1.0.0

Otherwise when downloading the provider release, the provider structure has an unexpected directory nesting, i.e.
the last directory of providers/registry.terraform.io/edgelesssys/constellation/2.14.0/darwin_arm64/terraform-provider-constellation_2.14.0_darwin_arm64 should not be there, and leads to TF not finding the binary.

Proposed change(s)

  • only zip the binary and not the directory

Additional info

Checklist

  • Update docs
  • Add labels (e.g., for changelog category)
  • Is PR title adequate for changelog?
  • Link to Milestone

Copy link

netlify bot commented Dec 27, 2023

Deploy Preview for constellation-docs canceled.

Name Link
🔨 Latest commit 138ea19
🔍 Latest deploy log https://app.netlify.com/sites/constellation-docs/deploys/658c4d5cd8b2c80008982626

@elchead elchead force-pushed the fix/ci/provider-release branch from 3a0b765 to 0f752f9 Compare December 27, 2023 16:11
@elchead elchead force-pushed the fix/ci/provider-release branch from 0f752f9 to 138ea19 Compare December 27, 2023 16:14
@elchead elchead marked this pull request as ready for review December 27, 2023 16:17
@elchead elchead added this to the v2.15.0 milestone Dec 27, 2023
@elchead elchead added the no changelog Change won't be listed in release changelog label Dec 27, 2023
@elchead elchead merged commit 903411e into main Dec 27, 2023
5 checks passed
@elchead elchead deleted the fix/ci/provider-release branch December 27, 2023 16:43
elchead added a commit that referenced this pull request Dec 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog Change won't be listed in release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants